Enhancements and Bug Fixes for Improved Compatibility and Functionality #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsarsars1
commented
Jul 3, 2023
arsarsars1
commented
- Added accessibility enhancements to ensure compatibility with the iOS platform.
- Fixed Firebase authentication to work seamlessly on both iOS and Android platforms.
- Removed flutter_apns dependency as it was causing disconnection issues.
- fix the firebase auth to run on both platforms - removed flutter_apns because it disconnected
|
First of all thank you for your contribution. Having said that, there are a couple of things that I don't like in this PR:
|
|
Hi, thank you for your response and for reviewing the PR. I noticed that the APNS (Apple Push Notification Service) was disconnected from the Flutter code, which caused issues with iOS crash analytics. To resolve this, I removed the APNS integration. Thank you.

… On 03-Jul-2023, at 4:54 PM, Franco Bugnano ***@***.***> wrote:
First of all thank you for your contribution.
Before being able to accept any PR, no matter how small, we require every contributor to sign either the Individual CLA or the corporate CLA that you find in this repo, and email it to ***@***.*** ***@***.***>
Having said that, there are a couple of things that I don't like in this PR:
Please don't reformat the sources, as it makes it nearly impossible to understand what are actual changes, and what are only automated formatting changes
We don't use Firebase for push notifications on iOS, so removing the flutter_apns dependency results in breaking the push notifications on iOS
—
Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AICXBKJEYPMCTR3YHZYH5WDXOKXHBANCNFSM6AAAAAAZ4IU5AE>.
You are receiving this because you authored the thread.
|
|
On 03-Jul-2023, at 4:59 PM, Abdul Rehman (A.R.S) ***@***.***> wrote:
Hi, thank you for your response and for reviewing the PR. I noticed that the APNS (Apple Push Notification Service) was disconnected from the Flutter code, which caused issues with iOS crash analytics. To resolve this, I removed the APNS integration. Thank you.

…> On 03-Jul-2023, at 4:54 PM, Franco Bugnano ***@***.***> wrote:
>
>
> First of all thank you for your contribution.
> Before being able to accept any PR, no matter how small, we require every contributor to sign either the Individual CLA or the corporate CLA that you find in this repo, and email it to ***@***.*** ***@***.***>
> Having said that, there are a couple of things that I don't like in this PR:
>
> Please don't reformat the sources, as it makes it nearly impossible to understand what are actual changes, and what are only automated formatting changes
> We don't use Firebase for push notifications on iOS, so removing the flutter_apns dependency results in breaking the push notifications on iOS
> —
> Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AICXBKJEYPMCTR3YHZYH5WDXOKXHBANCNFSM6AAAAAAZ4IU5AE>.
> You are receiving this because you authored the thread.
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.